From 0a85fc4d4e3d3876b81b328b8324fd632990ee4f Mon Sep 17 00:00:00 2001 From: Mattia Iavarone Date: Mon, 28 Jan 2019 01:50:39 +0100 Subject: [PATCH] Correctly release pools --- .../main/gles/com/otaliastudios/cameraview/MediaEncoder.java | 3 +++ .../gles/com/otaliastudios/cameraview/TextureMediaEncoder.java | 1 + 2 files changed, 4 insertions(+) diff --git a/cameraview/src/main/gles/com/otaliastudios/cameraview/MediaEncoder.java b/cameraview/src/main/gles/com/otaliastudios/cameraview/MediaEncoder.java index 73a828ab..cf999f1d 100644 --- a/cameraview/src/main/gles/com/otaliastudios/cameraview/MediaEncoder.java +++ b/cameraview/src/main/gles/com/otaliastudios/cameraview/MediaEncoder.java @@ -163,6 +163,9 @@ abstract class MediaEncoder { mMediaCodec.stop(); mMediaCodec.release(); mMediaCodec = null; + mOutputBufferPool.clear(); + mOutputBufferPool = null; + mBuffers = null; onRelease(); } diff --git a/cameraview/src/main/gles/com/otaliastudios/cameraview/TextureMediaEncoder.java b/cameraview/src/main/gles/com/otaliastudios/cameraview/TextureMediaEncoder.java index 113a7c67..968afdaa 100644 --- a/cameraview/src/main/gles/com/otaliastudios/cameraview/TextureMediaEncoder.java +++ b/cameraview/src/main/gles/com/otaliastudios/cameraview/TextureMediaEncoder.java @@ -134,6 +134,7 @@ class TextureMediaEncoder extends VideoMediaEncoder @Override void onRelease() { + mFramePool.clear(); if (mWindow != null) { mWindow.release(); mWindow = null;