From 14c8a4d6b810a45c0a168a9519b06adb28f72366 Mon Sep 17 00:00:00 2001 From: Mattia Iavarone Date: Thu, 12 Dec 2019 18:33:52 +0100 Subject: [PATCH] Test --- .../java/com/otaliastudios/cameraview/tools/RetryRule.java | 2 ++ .../com/otaliastudios/cameraview/engine/CameraEngine.java | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/cameraview/src/androidTest/java/com/otaliastudios/cameraview/tools/RetryRule.java b/cameraview/src/androidTest/java/com/otaliastudios/cameraview/tools/RetryRule.java index 1b54bf6f..4e4255ab 100644 --- a/cameraview/src/androidTest/java/com/otaliastudios/cameraview/tools/RetryRule.java +++ b/cameraview/src/androidTest/java/com/otaliastudios/cameraview/tools/RetryRule.java @@ -33,6 +33,8 @@ public class RetryRule implements TestRule { base.evaluate(); return; } catch (Throwable throwable) { + LOG.e("[RETRY] Test failed.", retries.get(), + "retries available..."); caught = throwable; } } diff --git a/cameraview/src/main/java/com/otaliastudios/cameraview/engine/CameraEngine.java b/cameraview/src/main/java/com/otaliastudios/cameraview/engine/CameraEngine.java index f6eca562..0be5fe95 100644 --- a/cameraview/src/main/java/com/otaliastudios/cameraview/engine/CameraEngine.java +++ b/cameraview/src/main/java/com/otaliastudios/cameraview/engine/CameraEngine.java @@ -367,10 +367,10 @@ public abstract class CameraEngine implements // This thread is likely stuck. The reason might be deadlock issues in the internal // camera implementation, at least in emulators: see Camera1Engine and Camera2Engine // onStopEngine() implementation and comments. - LOG.w("DESTROY: Could not destroy synchronously after 6 seconds.", + LOG.e("DESTROY: Could not destroy synchronously after 6 seconds.", "Current thread:", Thread.currentThread(), "Handler thread: ", mHandler.getThread()); - // TODO find a solution + // TODO Should we find a solution or is this emulator only? } } catch (InterruptedException ignore) {} }