diff --git a/cameraview/src/main/java/com/otaliastudios/cameraview/filter/BaseFilter.java b/cameraview/src/main/java/com/otaliastudios/cameraview/filter/BaseFilter.java index 1cfa900b..4a1b0334 100644 --- a/cameraview/src/main/java/com/otaliastudios/cameraview/filter/BaseFilter.java +++ b/cameraview/src/main/java/com/otaliastudios/cameraview/filter/BaseFilter.java @@ -19,7 +19,7 @@ import java.nio.FloatBuffer; * to be changed. Most effects can be rendered by simply changing the fragment shader, thus * by overriding {@link #getFragmentShader()}. * - * All {@link BaseFilter}s should have a no-op public constructor. + * All {@link BaseFilter}s should have a no-arguments public constructor. * This class will try to automatically implement {@link #copy()} thanks to this. * If your filter implements public parameters, please implement {@link OneParameterFilter} * and {@link TwoParameterFilter} to handle them and have them passed automatically to copies. @@ -226,9 +226,9 @@ public abstract class BaseFilter implements Filter { try { return getClass().newInstance(); } catch (IllegalAccessException e) { - throw new RuntimeException("Filters should have a public no-op constructor.", e); + throw new RuntimeException("Filters should have a public no-arguments constructor.", e); } catch (InstantiationException e) { - throw new RuntimeException("Filters should have a public no-op constructor.", e); + throw new RuntimeException("Filters should have a public no-arguments constructor.", e); } } } diff --git a/cameraview/src/main/java/com/otaliastudios/cameraview/filter/Filter.java b/cameraview/src/main/java/com/otaliastudios/cameraview/filter/Filter.java index 0a20b710..7a03f9c0 100644 --- a/cameraview/src/main/java/com/otaliastudios/cameraview/filter/Filter.java +++ b/cameraview/src/main/java/com/otaliastudios/cameraview/filter/Filter.java @@ -19,7 +19,7 @@ import java.io.File; * Advanced users can create custom filters using GLES. * It is recommended to extend {@link BaseFilter} instead of this class. * - * All {@link Filter}s should have a no-op public constructor. + * All {@link Filter}s should have a no-arguments public constructor. * This ensures that you can pass the filter class to XML attribute {@code app:cameraFilter}, * and also helps {@link BaseFilter} automatically make a copy of the filter. * diff --git a/cameraview/src/main/java/com/otaliastudios/cameraview/video/SnapshotVideoRecorder.java b/cameraview/src/main/java/com/otaliastudios/cameraview/video/SnapshotVideoRecorder.java index f19a8555..87b1231b 100644 --- a/cameraview/src/main/java/com/otaliastudios/cameraview/video/SnapshotVideoRecorder.java +++ b/cameraview/src/main/java/com/otaliastudios/cameraview/video/SnapshotVideoRecorder.java @@ -173,8 +173,12 @@ public class SnapshotVideoRecorder extends VideoRecorder implements RendererFram } // Engine - mEncoderEngine = new MediaEncoderEngine(mResult.file, videoEncoder, audioEncoder, - mResult.maxDuration, mResult.maxSize, SnapshotVideoRecorder.this); + mEncoderEngine = new MediaEncoderEngine(mResult.file, + videoEncoder, + audioEncoder, + mResult.maxDuration, + mResult.maxSize, + SnapshotVideoRecorder.this); mEncoderEngine.notify(TextureMediaEncoder.FILTER_EVENT, mCurrentFilter); mEncoderEngine.start(); mResult.rotation = 0; // We will rotate the result instead.