From c113933b60cd2919cb1ad3340c303386dab31e9a Mon Sep 17 00:00:00 2001 From: MatFl Date: Sat, 28 Jul 2018 03:32:22 +0200 Subject: [PATCH 1/2] Prevent context leak through SystemSensorManager (#245) --- .../utils/com/otaliastudios/cameraview/OrientationHelper.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cameraview/src/main/utils/com/otaliastudios/cameraview/OrientationHelper.java b/cameraview/src/main/utils/com/otaliastudios/cameraview/OrientationHelper.java index 99c2cb17..8006d095 100644 --- a/cameraview/src/main/utils/com/otaliastudios/cameraview/OrientationHelper.java +++ b/cameraview/src/main/utils/com/otaliastudios/cameraview/OrientationHelper.java @@ -22,7 +22,7 @@ class OrientationHelper { OrientationHelper(Context context, @NonNull Callback callback) { mCallback = callback; - mListener = new OrientationEventListener(context, SensorManager.SENSOR_DELAY_NORMAL) { + mListener = new OrientationEventListener(context.getApplicationContext(), SensorManager.SENSOR_DELAY_NORMAL) { @Override public void onOrientationChanged(int orientation) { @@ -72,4 +72,4 @@ class OrientationHelper { int getDisplayOffset() { return mDisplayOffset; } -} \ No newline at end of file +} From 4c6a8db0c398b6334e47b41c226660a9c7d0fffb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Wo=C5=9B?= Date: Tue, 31 Jul 2018 03:25:10 +0200 Subject: [PATCH 2/2] Fix README selector example (#248) --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 031e3140..a78546d7 100644 --- a/README.md +++ b/README.md @@ -370,7 +370,7 @@ to just square sizes: ```java SizeSelector width = SizeSelectors.minWidth(1000); -SizeSelector height = SizeSelectors.minWidth(2000); +SizeSelector height = SizeSelectors.minHeight(2000); SizeSelector dimensions = SizeSelectors.and(width, height); // Matches sizes bigger than 1000x2000. SizeSelector ratio = SizeSelectors.aspectRatio(AspectRatio.of(1, 1), 0); // Matches 1:1 sizes.