From a05e1416cddfb86e7e3d5b746f14d6ef87a629ad Mon Sep 17 00:00:00 2001 From: Giacomo Randazzo Date: Fri, 22 Mar 2019 10:27:08 +0100 Subject: [PATCH] Bug fix --- .../otaliastudios/cameraview/SnapshotVideoRecorder.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/cameraview/src/main/java/com/otaliastudios/cameraview/SnapshotVideoRecorder.java b/cameraview/src/main/java/com/otaliastudios/cameraview/SnapshotVideoRecorder.java index 8316ddba..f0141153 100644 --- a/cameraview/src/main/java/com/otaliastudios/cameraview/SnapshotVideoRecorder.java +++ b/cameraview/src/main/java/com/otaliastudios/cameraview/SnapshotVideoRecorder.java @@ -136,7 +136,12 @@ class SnapshotVideoRecorder extends VideoRecorder implements GlCameraPreview.Ren mOverlaySurfaceTexture.updateTexImage(); mOverlaySurfaceTexture.getTransformMatrix(textureFrame.overlayTransform); } - mEncoderEngine.notify(TextureMediaEncoder.FRAME_EVENT, textureFrame); + // Sometimes when the video ends an Exception is thrown saying that nofify was called on + // a null object. This might be highlighting a bigger problem, but checking for null + // fixes the Exception. + if (mEncoderEngine != null) { + mEncoderEngine.notify(TextureMediaEncoder.FRAME_EVENT, textureFrame); + } } if (mCurrentState == STATE_RECORDING && mDesiredState == STATE_NOT_RECORDING) {