From b15216b5b8685cb7025fe9ea9bd45025d82d98a7 Mon Sep 17 00:00:00 2001 From: Suneet Agrawal Date: Mon, 5 Aug 2019 14:32:10 +0530 Subject: [PATCH] code refacor --- .../java/com/otaliastudios/cameraview/CameraView.java | 11 +++-------- .../cameraview/preview/GlCameraPreview.java | 2 +- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/cameraview/src/main/java/com/otaliastudios/cameraview/CameraView.java b/cameraview/src/main/java/com/otaliastudios/cameraview/CameraView.java index 97795f98..bd7f9ac3 100644 --- a/cameraview/src/main/java/com/otaliastudios/cameraview/CameraView.java +++ b/cameraview/src/main/java/com/otaliastudios/cameraview/CameraView.java @@ -2133,17 +2133,12 @@ public class CameraView extends FrameLayout implements LifecycleObserver { //region Effects public void setFilter(@NonNull Filters filter) { - if (mCameraPreview instanceof GlCameraPreview) { - Filter shaderEffect = filter.newInstance(); - ((GlCameraPreview) mCameraPreview).setShaderEffect(shaderEffect); - } else { - LOG.w("setFilter", "setFilter is supported only for GLSurfaceView"); - } + setFilter(filter.newInstance()); } - public void setFilter(@NonNull Filter shaderEffect) { + public void setFilter(@NonNull Filter filter) { if (mCameraPreview instanceof GlCameraPreview) { - ((GlCameraPreview) mCameraPreview).setShaderEffect(shaderEffect); + ((GlCameraPreview) mCameraPreview).setShaderEffect(filter); } else { LOG.w("setFilter", "setFilter is supported only for GLSurfaceView"); } diff --git a/cameraview/src/main/java/com/otaliastudios/cameraview/preview/GlCameraPreview.java b/cameraview/src/main/java/com/otaliastudios/cameraview/preview/GlCameraPreview.java index b7cd7283..06fd4abf 100644 --- a/cameraview/src/main/java/com/otaliastudios/cameraview/preview/GlCameraPreview.java +++ b/cameraview/src/main/java/com/otaliastudios/cameraview/preview/GlCameraPreview.java @@ -317,8 +317,8 @@ public class GlCameraPreview extends CameraPreview