From d3ceca4c51928de57d12b6916df8ee744315a60a Mon Sep 17 00:00:00 2001 From: Mattia Iavarone Date: Wed, 17 Jul 2019 18:38:45 -0300 Subject: [PATCH] Do not use ViewCompat --- .../com/otaliastudios/cameraview/CameraView.java | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/cameraview/src/main/java/com/otaliastudios/cameraview/CameraView.java b/cameraview/src/main/java/com/otaliastudios/cameraview/CameraView.java index d7eed69c..e54bfaab 100644 --- a/cameraview/src/main/java/com/otaliastudios/cameraview/CameraView.java +++ b/cameraview/src/main/java/com/otaliastudios/cameraview/CameraView.java @@ -6,7 +6,6 @@ import android.annotation.TargetApi; import android.app.Activity; import androidx.annotation.VisibleForTesting; -import androidx.core.view.ViewCompat; import androidx.lifecycle.Lifecycle; import androidx.lifecycle.LifecycleObserver; import androidx.lifecycle.LifecycleOwner; @@ -830,12 +829,14 @@ public class CameraView extends FrameLayout implements LifecycleObserver { */ public void setPreview(@NonNull Preview preview) { boolean isNew = preview != mPreview; - if (!isNew) return; - mPreview = preview; - if (!ViewCompat.isAttachedToWindow(this) && mCameraPreview != null) { - // Null the preview: will create another when re-attaching. - mCameraPreview.onDestroy(); - mCameraPreview = null; + if (isNew) { + mPreview = preview; + boolean isAttachedToWindow = getWindowToken() != null; + if (!isAttachedToWindow && mCameraPreview != null) { + // Null the preview: will create another when re-attaching. + mCameraPreview.onDestroy(); + mCameraPreview = null; + } } }