diff --git a/cameraview/src/androidTest/java/com/otaliastudios/cameraview/CameraViewTest.java b/cameraview/src/androidTest/java/com/otaliastudios/cameraview/CameraViewTest.java index a524788b..d4cb6e55 100644 --- a/cameraview/src/androidTest/java/com/otaliastudios/cameraview/CameraViewTest.java +++ b/cameraview/src/androidTest/java/com/otaliastudios/cameraview/CameraViewTest.java @@ -164,6 +164,7 @@ public class CameraViewTest extends BaseTest { // Self managed GestureParser gestures = new GestureParser(empty); assertEquals(cameraView.getPlaySounds(), CameraView.DEFAULT_PLAY_SOUNDS); + assertEquals(cameraView.getUseDeviceOrientation(), CameraView.DEFAULT_USE_DEVICE_ORIENTATION); assertEquals(cameraView.getGestureAction(Gesture.TAP), gestures.getTapAction()); assertEquals(cameraView.getGestureAction(Gesture.LONG_TAP), gestures.getLongTapAction()); assertEquals(cameraView.getGestureAction(Gesture.PINCH), gestures.getPinchAction()); @@ -544,9 +545,17 @@ public class CameraViewTest extends BaseTest { @Test public void testSetPlaySounds() { cameraView.setPlaySounds(true); - assertEquals(cameraView.getPlaySounds(), true); + assertTrue(cameraView.getPlaySounds()); cameraView.setPlaySounds(false); - assertEquals(cameraView.getPlaySounds(), false); + assertFalse(cameraView.getPlaySounds()); + } + + @Test + public void testSetUseDeviceOrientation() { + cameraView.setUseDeviceOrientation(true); + assertTrue(cameraView.getUseDeviceOrientation()); + cameraView.setUseDeviceOrientation(false); + assertFalse(cameraView.getUseDeviceOrientation()); } @Test diff --git a/cameraview/src/main/java/com/otaliastudios/cameraview/CameraView.java b/cameraview/src/main/java/com/otaliastudios/cameraview/CameraView.java index a344f03b..abd155eb 100644 --- a/cameraview/src/main/java/com/otaliastudios/cameraview/CameraView.java +++ b/cameraview/src/main/java/com/otaliastudios/cameraview/CameraView.java @@ -98,6 +98,7 @@ public class CameraView extends FrameLayout implements LifecycleObserver { final static long DEFAULT_AUTOFOCUS_RESET_DELAY_MILLIS = 3000; final static boolean DEFAULT_PLAY_SOUNDS = true; + final static boolean DEFAULT_USE_DEVICE_ORIENTATION = true; // Self managed parameters private boolean mPlaySounds; @@ -153,7 +154,7 @@ public class CameraView extends FrameLayout implements LifecycleObserver { // Self managed boolean playSounds = a.getBoolean(R.styleable.CameraView_cameraPlaySounds, DEFAULT_PLAY_SOUNDS); - boolean useDeviceOrientation = a.getBoolean(R.styleable.CameraView_cameraUseDeviceOrientation, true); + boolean useDeviceOrientation = a.getBoolean(R.styleable.CameraView_cameraUseDeviceOrientation, DEFAULT_USE_DEVICE_ORIENTATION); mExperimental = a.getBoolean(R.styleable.CameraView_cameraExperimental, false); mPreview = controls.getPreview(); mEngine = controls.getEngine();