feat: 优化代码

app/src/main/java/io/legado/app/ui/widget/font/FontSelectDialog.kt

@@ -89,17 +89,14 @@ class FontSelectDialog : BaseDialogFragment(),
     override fun onMenuItemClick(item: MenuItem?): Boolean {
         when (item?.itemId) {
             R.id.menu_default -> {
-                val cb = (parentFragment as? CallBack) ?: (activity as? CallBack)
+                val requireContext = requireContext()
-                cb?.let {
+                requireContext.alert(titleResource = R.string.system_typeface) {
-                    val requireContext = requireContext()
+                    items(requireContext.resources.getStringArray(R.array.system_typefaces).toList()) { _, i ->
-                    requireContext.alert(titleResource = R.string.system_typeface) {
+                        AppConfig.systemTypefaces = i
-                        items(requireContext.resources.getStringArray(R.array.system_typefaces).toList()) { _, i ->
+                        onDefaultFontChange()
-                            AppConfig.systemTypefaces = i
+                        dismiss()
-                            onDefaultFontChange(it)
+                    }
-                        }
+                }.show()
-                    }.show()
-                }
-                dismiss()
             }
             R.id.menu_other -> {
                 openFolder()
@@ -212,12 +209,9 @@ class FontSelectDialog : BaseDialogFragment(),
         launch(IO) {
             file.copyTo(FileUtils.createFileIfNotExist(fontFolder, file.name), true)
                 .absolutePath.let { path ->
-                val cb = (parentFragment as? CallBack) ?: (activity as? CallBack)
+                if (callBack?.curFontPath != path) {
-                cb?.let {
+                    withContext(Main) {
-                    if (it.curFontPath != path) {
+                        callBack?.selectFile(path)
-                        withContext(Main) {
-                            it.selectFile(path)
-                        }
                     }
                 }
             }
@@ -226,9 +220,7 @@ class FontSelectDialog : BaseDialogFragment(),
     }
 
     override fun curFilePath(): String {
-        return (parentFragment as? CallBack)?.curFontPath
+        return callBack?.curFontPath ?: ""
-            ?: (activity as? CallBack)?.curFontPath
-            ?: ""
     }
 
     override fun onFilePicked(requestCode: Int, currentPath: String) {
@@ -263,14 +255,17 @@ class FontSelectDialog : BaseDialogFragment(),
         }
     }
 
-    private fun onDefaultFontChange(callBack: CallBack) {
+    private fun onDefaultFontChange() {
         if (curFilePath() == "") {
             postEvent(EventBus.UP_CONFIG, true)
         } else {
-            callBack.selectFile("")
+            callBack?.selectFile("")
         }
     }
 
+    private val callBack: CallBack?
+        get() = (parentFragment as? CallBack) ?: (activity as? CallBack)
+
     interface CallBack {
         fun selectFile(path: String)
         val curFontPath: String